]> www.infradead.org Git - users/hch/misc.git/commit
bpf: Fix UAF via mismatching bpf_prog/attachment RCU flavors
authorJann Horn <jannh@google.com>
Tue, 10 Dec 2024 16:32:13 +0000 (17:32 +0100)
committerAndrii Nakryiko <andrii@kernel.org>
Tue, 10 Dec 2024 18:14:02 +0000 (10:14 -0800)
commitef1b808e3b7c98612feceedf985c2fbbeb28f956
tree5d50f07351c8df31a38dce909f50075f061e8afe
parent11d5245f608f8ac01c97b93f31497cef7b96e457
bpf: Fix UAF via mismatching bpf_prog/attachment RCU flavors

Uprobes always use bpf_prog_run_array_uprobe() under tasks-trace-RCU
protection. But it is possible to attach a non-sleepable BPF program to a
uprobe, and non-sleepable BPF programs are freed via normal RCU (see
__bpf_prog_put_noref()). This leads to UAF of the bpf_prog because a normal
RCU grace period does not imply a tasks-trace-RCU grace period.

Fix it by explicitly waiting for a tasks-trace-RCU grace period after
removing the attachment of a bpf_prog to a perf_event.

Fixes: 8c7dcb84e3b7 ("bpf: implement sleepable uprobes by chaining gps")
Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Suggested-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/bpf/20241210-bpf-fix-actual-uprobe-uaf-v1-1-19439849dd44@google.com
kernel/trace/bpf_trace.c