]> www.infradead.org Git - users/jedix/linux-maple.git/commit
lpfc: Fix driver usage of 128B WQEs when WQ_CREATE is
authorJames Smart <james.smart@broadcom.com>
Wed, 12 Jul 2017 22:39:45 +0000 (18:39 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 14 Jul 2017 00:12:55 +0000 (17:12 -0700)
commitef18a5a354d5f5493200c4ae62b95a09105d4db8
tree6ac6f89881bec9eff00cbf74c62a5ca15892c117
parent0aeca58e59edef6e0df2499ff6bf99175fcc516c
lpfc: Fix driver usage of 128B WQEs when WQ_CREATE is

[backport of 8c434f8b07d99c4f0728ed144108839a367c72c0]
From: rkennedy <dick.kennedy@avagotech.com>

Orabug: 26439257

There are two versions of a structure for queue creation and setup that the
driver shares with FW. The driver was only treating as version 0.

Verify WQ_CREATE with 128B WQEs in V0 and V1.

Code review of another bug showed the driver passing
128B WQEs and 8 pages in WQ CREATE and V0.
Code inspection/instrumentation showed that the driver
uses V0 in WQ_CREATE and if the caller passes queue->entry_size
128B, the driver sets the hdr_version to V1 so all is good.
When I tested the V1 WQ_CREATE, the mailbox failed causing
the driver to unload.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c