]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot
authorShenghao Ding <shenghao-ding@ti.com>
Tue, 13 May 2025 08:59:47 +0000 (16:59 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 13 May 2025 09:03:19 +0000 (11:03 +0200)
commiteef5bccfb1b7751ce5368739ec0b1b1d14849552
tree225e398c4ede51ae76ad5203c497ee0bb13f2f3a
parent6f174daebe59a0cadbecd793182b0d3ce4e912c1
ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot

After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c
and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c,
However, tasdevice_remove() used for not only for I2C but for SPI being
still in that lib caused ld issue.
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: tasdevice_remove
   >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33)
   >>>               vmlinux.o:(tas2781_hda_remove)
To fix this issue, the implementation of tasdevice_remove was moved from
tas2781-comlib-i2c.c to tas2781-comlib.c.

Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111855.FP2fScKA-lkp@intel.com/__;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJD
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Link: https://patch.msgid.link/20250513085947.1121-1-shenghao-ding@ti.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/soc/codecs/tas2781-comlib-i2c.c
sound/soc/codecs/tas2781-comlib.c