]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: light: Add check for array bounds in veml6075_read_int_time_ms
authorKaran Sanghavi <karansanghvi98@gmail.com>
Thu, 20 Feb 2025 17:34:36 +0000 (17:34 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 11 Mar 2025 19:09:17 +0000 (19:09 +0000)
commitee735aa33db16c1fb5ebccbaf84ad38f5583f3cc
treeae11fc824b9871fadbf89373b12f9bec4f8e5682
parent8d534275f7400d490d16ed81d08f5ae6bda09c04
iio: light: Add check for array bounds in veml6075_read_int_time_ms

The array contains only 5 elements, but the index calculated by
veml6075_read_int_time_index can range from 0 to 7,
which could lead to out-of-bounds access. The check prevents this issue.

Coverity Issue
CID 1574309: (#1 of 1): Out-of-bounds read (OVERRUN)
overrun-local: Overrunning array veml6075_it_ms of 5 4-byte
elements at element index 7 (byte offset 31) using
index int_index (which evaluates to 7)

This is hardening against potentially broken hardware. Good to have
but not necessary to backport.

Fixes: 3b82f43238ae ("iio: light: add VEML6075 UVA and UVB light sensor driver")
Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/Z7dnrEpKQdRZ2qFU@Emma
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/veml6075.c