]> www.infradead.org Git - users/jedix/linux-maple.git/commit
trace/fgraph: Fix the warning caused by missing unregister notifier
authorYe Weihua <yeweihua4@huawei.com>
Mon, 18 Aug 2025 07:33:32 +0000 (07:33 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 20 Aug 2025 13:21:03 +0000 (09:21 -0400)
commitedede7a6dcd7435395cf757d053974aaab6ab1c2
treee9a2f50e155a0b93b92f1aeea436c94dda2694c2
parentcd6e4faba96fe41d6b686e144b96dad5e6f2e771
trace/fgraph: Fix the warning caused by missing unregister notifier

This warning was triggered during testing on v6.16:

notifier callback ftrace_suspend_notifier_call already registered
WARNING: CPU: 2 PID: 86 at kernel/notifier.c:23 notifier_chain_register+0x44/0xb0
...
Call Trace:
 <TASK>
 blocking_notifier_chain_register+0x34/0x60
 register_ftrace_graph+0x330/0x410
 ftrace_profile_write+0x1e9/0x340
 vfs_write+0xf8/0x420
 ? filp_flush+0x8a/0xa0
 ? filp_close+0x1f/0x30
 ? do_dup2+0xaf/0x160
 ksys_write+0x65/0xe0
 do_syscall_64+0xa4/0x260
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

When writing to the function_profile_enabled interface, the notifier was
not unregistered after start_graph_tracing failed, causing a warning the
next time function_profile_enabled was written.

Fixed by adding unregister_pm_notifier in the exception path.

Link: https://lore.kernel.org/20250818073332.3890629-1-yeweihua4@huawei.com
Fixes: 4a2b8dda3f870 ("tracing/function-graph-tracer: fix a regression while suspend to disk")
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Ye Weihua <yeweihua4@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/fgraph.c