]> www.infradead.org Git - users/jedix/linux-maple.git/commit
emulex/benet: correct command version selection in be_cmd_get_stats()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 19 May 2025 14:17:19 +0000 (07:17 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 May 2025 03:30:51 +0000 (20:30 -0700)
commitedb888d29748cee674006a52e544925dacc7728e
tree47fd180f03d6c8d42d2203d4a496d7ebec7a40c8
parent220a29d0af240c7ebf6ac1efae8b7a339f7e2026
emulex/benet: correct command version selection in be_cmd_get_stats()

Logic here always sets hdr->version to 2 if it is not a BE3 or Lancer chip,
even if it is BE2. Use 'else if' to prevent multiple assignments, setting
version 0 for BE2, version 1 for BE3 and Lancer, and version 2 for others.
Fixes potential incorrect version setting when BE2_chip and
BE3_chip/lancer_chip checks could both be true.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250519141731.691136-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/emulex/benet/be_cmds.c