]> www.infradead.org Git - users/jedix/linux-maple.git/commit
md/raid5: avoid races when changing cache size.
authorNeilBrown <neilb@suse.com>
Mon, 6 Jul 2015 02:49:23 +0000 (12:49 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Sep 2015 17:26:13 +0000 (19:26 +0200)
commited8b312450dae5e5a9e5bc022e1261a2e6414984
treeea904c5d68835a9e5716881d330eb0a4eedf1c12
parentcd6a4dd89b4cdcc220c255ba5fe29b677d431cbd
md/raid5: avoid races when changing cache size.

commit 2d5b569b665ea6d0b15c52529ff06300de81a7ce upstream.

Cache size can grow or shrink due to various pressures at
any time.  So when we resize the cache as part of a 'grow'
operation (i.e. change the size to allow more devices) we need
to blocks that automatic growing/shrinking.

So introduce a mutex.  auto grow/shrink uses mutex_trylock()
and just doesn't bother if there is a blockage.
Resizing the whole cache holds the mutex to ensure that
the correct number of new stripes is allocated.

This bug can result in some stripes not being freed when an
array is stopped.  This leads to the kmem_cache not being
freed and a subsequent array can try to use the same kmem_cache
and get confused.

Fixes: edbe83ab4c27 ("md/raid5: allow the stripe_cache to grow and shrink.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/raid5.c
drivers/md/raid5.h