]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: hi556: Fix memory leak (on error) in hi556_check_hwcfg()
authorHans de Goede <hdegoede@redhat.com>
Thu, 19 Dec 2024 19:27:30 +0000 (20:27 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 14:22:36 +0000 (15:22 +0100)
commited554da65abd0c561e40d35272d1a61d030fe977
tree59a46e13b1eef01fbfa60fe3cf6f3cbd444860fb
parent035371c9e5098018b8512efc6a8812912469480c
media: hi556: Fix memory leak (on error) in hi556_check_hwcfg()

Commit 7d968b5badfc ("media: hi556: Return -EPROBE_DEFER if no endpoint is
found") moved the v4l2_fwnode_endpoint_alloc_parse() call in
hi556_check_hwcfg() up, but it did not make the error-exit paths between
the old and new call-site use "goto check_hwcfg_error;" to free the bus_cfg
on errors.

Add the missing "goto check_hwcfg_error;" statements to fix a memleak on
early error-exits from hi556_check_hwcfg().

Fixes: 7d968b5badfc ("media: hi556: Return -EPROBE_DEFER if no endpoint is found")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/hi556.c