]> www.infradead.org Git - users/hch/configfs.git/commit
drm/i915: move uapi.event outside spinlock in intel_crtc_vblank_work
authorLuca Coelho <luciano.coelho@intel.com>
Tue, 28 May 2024 11:29:01 +0000 (14:29 +0300)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Thu, 30 May 2024 10:38:05 +0000 (16:08 +0530)
commited43c40e1f10e0ee1d49b841ee35b23a3a7113ee
treebfaae8550e4f7b7190dd5016173b53b759bdf09b
parentb2c2f2df6f01174eefc1ea2aa9aef8b1a6c69575
drm/i915: move uapi.event outside spinlock in intel_crtc_vblank_work

In intel_crtc_vblank_work(), we access uapi.event before grabbing the
event_lock spinlock, but modify it inside the spinlock block.  This
causes some static analyzers to get confused and issue a warning.

The uapi.event value is not protected by the event_lock, so we can
safely move it out of the protected block to prevent false positives.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240528112901.476068-3-luciano.coelho@intel.com
drivers/gpu/drm/i915/display/intel_crtc.c