]> www.infradead.org Git - users/hch/configfs.git/commit
tools/mm: -Werror fixes in page-types/slabinfo
authorWladislav Wiebe <wladislav.kw@gmail.com>
Tue, 22 Oct 2024 17:21:13 +0000 (19:21 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 31 Oct 2024 03:14:11 +0000 (20:14 -0700)
commitece5897e5a10fcd56a317e32f2dc7219f366a5a8
tree4c4af8be96818682011cbdab00f975569fbcb211
parent5168a68eb78fa1c67a8b2d31d0642c7fd866cc12
tools/mm: -Werror fixes in page-types/slabinfo

Commit e6d2c436ff693 ("tools/mm: allow users to provide additional
cflags/ldflags") passes now CFLAGS to Makefile.  With this, build systems
with default -Werror enabled found:

slabinfo.c:1300:25: error: ignoring return value of 'chdir'
declared with attribute 'warn_unused_result' [-Werror=unused-result]
                         chdir("..");
                         ^~~~~~~~~~~
page-types.c:397:35: error: format '%lu' expects argument of type
'long unsigned int', but argument 2 has type 'uint64_t'
{aka 'long long unsigned int'} [-Werror=format=]
                         printf("%lu\t", mapcnt0);
                                 ~~^     ~~~~~~~
..

Fix page-types by using PRIu64 for uint64_t prints and check in slabinfo
for return code on chdir("..").

Link: https://lkml.kernel.org/r/c1ceb507-94bc-461c-934d-c19b77edd825@gmail.com
Fixes: e6d2c436ff69 ("tools/mm: allow users to provide additional cflags/ldflags")
Signed-off-by: Wladislav Wiebe <wladislav.kw@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Herton R. Krzesinski <herton@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/mm/page-types.c
tools/mm/slabinfo.c