]> www.infradead.org Git - users/dwmw2/linux.git/commit
ASoC: rockchip: Fix mono capture
authorCheng-Yi Chiang <cychiang@chromium.org>
Fri, 26 Jul 2019 04:42:02 +0000 (12:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2019 06:30:06 +0000 (08:30 +0200)
commitec10dcf3ae89ee4eb19dd788f773c72d0244b94b
tree1cd5dbbbbd37cc0d87464df45e1d623c75c69fa8
parent205cd0f91481f6f5f0cef89e8f4ff5b2b009caa2
ASoC: rockchip: Fix mono capture

[ Upstream commit 789e162a6255325325bd321ab0cd51dc7e285054 ]

This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0.
Revert "ASoC: rockchip: i2s: Support mono capture"

Previous discussion in

https://patchwork.kernel.org/patch/10147153/

explains the issue of the patch.
While device is configured as 1-ch, hardware is still
generating a 2-ch stream.
When user space reads the data and assumes it is a 1-ch stream,
the rate will be slower by 2x.

Revert the change so 1-ch is not supported.
User space can selectively take one channel data out of two channel
if 1-ch is preferred.
Currently, both channels record identical data.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Link: https://lore.kernel.org/r/20190726044202.26866-1-cychiang@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/rockchip/rockchip_i2s.c