]> www.infradead.org Git - users/hch/misc.git/commit
net: stmmac: platform: guarantee uniqueness of bus_id
authorQuentin Schulz <quentin.schulz@cherry.de>
Tue, 27 May 2025 11:56:23 +0000 (13:56 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 May 2025 08:51:43 +0000 (10:51 +0200)
commiteb7fd7aa35bfcc1e1fda4ecc42ccfcb526cdc780
tree1bd298a5a76a77208a53186636224545032ab9d5
parent271683bb2cf32e5126c592b5d5e6a756fa374fd9
net: stmmac: platform: guarantee uniqueness of bus_id

bus_id is currently derived from the ethernetX alias. If one is missing
for the device, 0 is used. If ethernet0 points to another stmmac device
or if there are 2+ stmmac devices without an ethernet alias, then bus_id
will be 0 for all of those.

This is an issue because the bus_id is used to generate the mdio bus id
(new_bus->id in drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
stmmac_mdio_register) and this needs to be unique.

This allows to avoid needing to define ethernet aliases for devices with
multiple stmmac controllers (such as the Rockchip RK3588) for multiple
stmmac devices to probe properly.

Obviously, the bus_id isn't guaranteed to be stable across reboots if no
alias is set for the device but that is easily fixed by simply adding an
alias if this is desired.

Fixes: 25c83b5c2e82 ("dt:net:stmmac: Add support to dwmac version 3.610 and 3.710")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20250527-stmmac-mdio-bus_id-v2-1-a5ca78454e3c@cherry.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c