]> www.infradead.org Git - users/jedix/linux-maple.git/commit
of: property: Increase NR_FWNODE_REFERENCE_ARGS
authorZijun Hu <quic_zijuhu@quicinc.com>
Tue, 25 Feb 2025 13:58:06 +0000 (21:58 +0800)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 26 Feb 2025 19:15:57 +0000 (13:15 -0600)
commiteb50844d728f11e87491f7c7af15a4a737f1159d
tree036220fdb1e446fb5f879d1ccfd38329d4c58a86
parent44d755c1d698f60e70a177f802d8482a8c833cec
of: property: Increase NR_FWNODE_REFERENCE_ARGS

Currently, the following two macros have different values:

// The maximal argument count for firmware node reference
 #define NR_FWNODE_REFERENCE_ARGS 8
// The maximal argument count for DT node reference
 #define MAX_PHANDLE_ARGS 16

It may cause firmware node reference's argument count out of range if
directly assign DT node reference's argument count to firmware's.

drivers/of/property.c:of_fwnode_get_reference_args() is doing the direct
assignment, so may cause firmware's argument count @args->nargs got out
of range, namely, in [9, 16].

Fix by increasing NR_FWNODE_REFERENCE_ARGS to 16 to meet DT requirement.
Will align both macros later to avoid such inconsistency.

Fixes: 3e3119d3088f ("device property: Introduce fwnode_property_get_reference_args")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20250225-fix_arg_count-v4-1-13cdc519eb31@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
include/linux/fwnode.h