]> www.infradead.org Git - users/dwmw2/linux.git/commit
drivers: net: xgene: Fix regression in CRC stripping
authorStephane Graber <stgraber@ubuntu.com>
Tue, 22 Mar 2022 22:42:06 +0000 (18:42 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2022 07:57:09 +0000 (09:57 +0200)
commiteb1ba8d1c3e2ca9817e24baad8fd1a418693fabc
treec203d1598c1f5b4d3f3122cec078a4e6b4809d93
parenta2368d10b7fbdd449130b43776dc174954ca02b0
drivers: net: xgene: Fix regression in CRC stripping

commit e9e6faeafaa00da1851bcf47912b0f1acae666b4 upstream.

All packets on ingress (except for jumbo) are terminated with a 4-bytes
CRC checksum. It's the responsability of the driver to strip those 4
bytes. Unfortunately a change dating back to March 2017 re-shuffled some
code and made the CRC stripping code effectively dead.

This change re-orders that part a bit such that the datalen is
immediately altered if needed.

Fixes: 4902a92270fb ("drivers: net: xgene: Add workaround for errata 10GE_8/ENET_11")
Cc: stable@vger.kernel.org
Signed-off-by: Stephane Graber <stgraber@ubuntu.com>
Tested-by: Stephane Graber <stgraber@ubuntu.com>
Link: https://lore.kernel.org/r/20220322224205.752795-1-stgraber@ubuntu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/apm/xgene/xgene_enet_main.c