]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/mgag200: Bind I2C lifetime to DRM device
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 13 May 2024 12:51:07 +0000 (14:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 17 May 2024 15:20:01 +0000 (17:20 +0200)
commiteb1ae34e48a09b7a1179c579aed042b032e408f4
treee2c401da8ae29d4a6c30a4bf270a17baa15e6cb5
parentecde5db1598aecab54cc392282c15114f526f05f
drm/mgag200: Bind I2C lifetime to DRM device

Managed cleanup with devm_add_action_or_reset() will release the I2C
adapter when the underlying Linux device goes away. But the connector
still refers to it, so this cleanup leaves behind a stale pointer
in struct drm_connector.ddc.

Bind the lifetime of the I2C adapter to the connector's lifetime by
using DRM's managed release. When the DRM device goes away (after
the Linux device) DRM will first clean up the connector and then
clean up the I2C adapter.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Fixes: b279df242972 ("drm/mgag200: Switch I2C code to managed cleanup")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.0+
Link: https://patchwork.freedesktop.org/patch/msgid/20240513125620.6337-3-tzimmermann@suse.de
drivers/gpu/drm/mgag200/mgag200_i2c.c