]> www.infradead.org Git - users/hch/misc.git/commit
[PATCH} hwmon: (jc42) Properly detect TSE2004-compliant devices again
authorJean Delvare <jdelvare@suse.de>
Mon, 14 Oct 2024 20:04:26 +0000 (22:04 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 15 Oct 2024 02:14:08 +0000 (19:14 -0700)
commiteabb03810194b75417b09cff8a526d26939736ac
treeeff09b52bb1f92f3a52e25ca683bfb3db217bc02
parent8e929cb546ee42c9a61d24fae60605e9e3192354
[PATCH} hwmon: (jc42) Properly detect TSE2004-compliant devices again

Commit b3e992f69c23 ("hwmon: (jc42)  Strengthen detect function")
attempted to make the detect function more robust for
TSE2004-compliant devices by checking capability bits which, according
to the JEDEC 21-C specification, should always be set. Unfortunately,
not all real-world implementations fully adhere to this specification,
so this change caused a regression.

Stop testing bit 7 (EVSD) of the Capabilities register, as it was
found to be 0 on one real-world device.

Also stop testing bits 0 (EVENT) and 2 (RANGE) as vendor datasheets
(Renesas TSE2004GB2B0, ST STTS2004) suggest that they may not always
be set either.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Message-ID: <20241014141204.026f4641@endymion.delvare>
Fixes: b3e992f69c23 ("hwmon: (jc42) Strengthen detect function")
Message-ID: <20241014220426.0c8f4d9c@endymion.delvare>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/jc42.c