]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/chrome: cros_ec_chardev: fix kernel data leak from ioctl
authorTzung-Bi Shih <tzungbi@kernel.org>
Fri, 24 Mar 2023 01:06:58 +0000 (09:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:49:12 +0000 (12:49 +0200)
commiteab28bfafcd1245a3510df9aa9eb940589956ea6
treebc9a6a88f35ee7a656077c9ba6f45389361c016b
parentb3168abd24245aa0775c5a387dcf94d36ca7e738
platform/chrome: cros_ec_chardev: fix kernel data leak from ioctl

[ Upstream commit b20cf3f89c56b5f6a38b7f76a8128bf9f291bbd3 ]

It is possible to peep kernel page's data by providing larger `insize`
in struct cros_ec_command[1] when invoking EC host commands.

Fix it by using zeroed memory.

[1]: https://elixir.bootlin.com/linux/v6.2/source/include/linux/platform_data/cros_ec_proto.h#L74

Fixes: eda2e30c6684 ("mfd / platform: cros_ec: Miscellaneous character device to talk with the EC")
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20230324010658.1082361-1-tzungbi@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/chrome/cros_ec_chardev.c