]> www.infradead.org Git - linux.git/commit
drm/xe: Don't free job in TDR
authorMatthew Brost <matthew.brost@intel.com>
Thu, 3 Oct 2024 00:16:57 +0000 (17:16 -0700)
committerMatthew Brost <matthew.brost@intel.com>
Fri, 11 Oct 2024 22:48:36 +0000 (15:48 -0700)
commitea2f6a77d0c40d97f4a4dc93fee4afe15d94926d
tree9b8fedb2209a7807c0fe0f190df9af0c269a84fa
parent90521df5fc43980e4575bd8c5b1cb62afe1a9f5f
drm/xe: Don't free job in TDR

Freeing job in TDR is not safe as TDR can pass the run_job thread
resulting in UAF. It is only safe for free job to naturally be called by
the scheduler. Rather free job in TDR, add to pending list.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2811
Cc: Matthew Auld <matthew.auld@intel.com>
Fixes: e275d61c5f3f ("drm/xe/guc: Handle timing out of signaled jobs gracefully")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241003001657.3517883-3-matthew.brost@intel.com
drivers/gpu/drm/xe/xe_guc_submit.c