]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/vmwgfx: Disable coherent dumb buffers without 3d
authorZack Rusin <zack.rusin@broadcom.com>
Fri, 16 Aug 2024 18:32:07 +0000 (14:32 -0400)
committerZack Rusin <zack.rusin@broadcom.com>
Mon, 26 Aug 2024 04:19:44 +0000 (00:19 -0400)
commite9fd436bb8fb9b9d31fdf07bbcdba6d30290c5e4
treefaec9e6d702ce2d84b0755293dd59367cc708796
parent50f1199250912568606b3778dc56646c10cb7b04
drm/vmwgfx: Disable coherent dumb buffers without 3d

Coherent surfaces make only sense if the host renders to them using
accelerated apis. Without 3d the entire content of dumb buffers stays
in the guest making all of the extra work they're doing to synchronize
between guest and host useless.

Configurations without 3d also tend to run with very low graphics
memory limits. The pinned console fb, mob cursors and graphical login
manager tend to run out of 16MB graphics memory that those guests use.

Fix it by making sure the coherent dumb buffers are only used on
configs with 3d enabled.

Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Fixes: d6667f0ddf46 ("drm/vmwgfx: Fix handling of dumb buffers")
Reported-by: Christian Heusel <christian@heusel.eu>
Closes: https://lore.kernel.org/all/0d0330f3-2ac0-4cd5-8075-7f1cbaf72a8e@heusel.eu
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.9+
Link: https://patchwork.freedesktop.org/patch/msgid/20240816183332.31961-4-zack.rusin@broadcom.com
Reviewed-by: Martin Krastev <martin.krastev@broadcom.com>
Reviewed-by: Maaz Mombasawala <maaz.mombasawala@broadcom.com>
Tested-by: Benjamin Coddington <bcodding@redhat.com>
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c