]> www.infradead.org Git - nvme.git/commit
block: remove the blk_integrity_profile structure
authorChristoph Hellwig <hch@lst.de>
Thu, 13 Jun 2024 08:48:15 +0000 (10:48 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 14 Jun 2024 16:20:06 +0000 (10:20 -0600)
commite9f5f44ad3725335d9c559c3c22cd3726152a7b1
tree7475356d258897bfa4a3b453996d2dbb54ca457f
parent63e649594ab19cc3122a2d0fc2c94b19932f0b19
block: remove the blk_integrity_profile structure

Block layer integrity configuration is a bit complex right now, as it
indirects through operation vectors for a simple two-dimensional
configuration:

 a) the checksum type of none, ip checksum, crc, crc64
 b) the presence or absence of a reference tag

Remove the integrity profile, and instead add a separate csum_type flag
which replaces the existing ip-checksum field and a new flag that
indicates the presence of the reference tag.

This removes up to two layers of indirect calls, remove the need to
offload the no-op verification of non-PI metadata to a workqueue and
generally simplifies the code. The downside is that block/t10-pi.c now
has to be built into the kernel when CONFIG_BLK_DEV_INTEGRITY is
supported.  Given that both nvme and SCSI require t10-pi.ko, it is loaded
for all usual configurations that enabled CONFIG_BLK_DEV_INTEGRITY
already, though.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240613084839.1044015-6-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
18 files changed:
block/Kconfig
block/Makefile
block/bio-integrity.c
block/blk-integrity.c
block/blk-mq.c
block/blk.h
block/t10-pi.c
drivers/md/dm-crypt.c
drivers/nvme/host/Kconfig
drivers/nvme/host/core.c
drivers/nvme/target/Kconfig
drivers/nvme/target/io-cmd-bdev.c
drivers/scsi/Kconfig
drivers/scsi/sd_dif.c
drivers/target/target_core_iblock.c
include/linux/blk-integrity.h
include/linux/blkdev.h
include/linux/t10-pi.h