]> www.infradead.org Git - users/dwmw2/linux.git/commit
hwmon: (ltc2991) Fix mixed signed/unsigned in DIV_ROUND_CLOSEST
authorDavid Lechner <dlechner@baylibre.com>
Wed, 15 Jan 2025 20:48:27 +0000 (14:48 -0600)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 15 Jan 2025 21:52:43 +0000 (13:52 -0800)
commite9b24deb84863c5a77dda5be57b6cb5bf4127b85
tree277b2929d70d20a7ec5b9463f7bfb7fcf885f6e6
parentb46ba47d7bb461a0969317be1f2e165c0571d6c5
hwmon: (ltc2991) Fix mixed signed/unsigned in DIV_ROUND_CLOSEST

Fix use of DIV_ROUND_CLOSEST where a possibly negative value is divided
by an unsigned type by casting the unsigned type to the signed type of
the same size (st->r_sense_uohm[channel] has type of u32).

The docs on the DIV_ROUND_CLOSEST macro explain that dividing a negative
value by an unsigned type is undefined behavior. The actual behavior is
that it converts both values to unsigned before doing the division, for
example:

    int ret = DIV_ROUND_CLOSEST(-100, 3U);

results in ret == 1431655732 instead of -33.

Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://lore.kernel.org/r/20250115-hwmon-ltc2991-fix-div-round-closest-v1-1-b4929667e457@baylibre.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc2991.c