]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amd/display: Replace assert with error message in dp_retrieve_lttpr_cap()
authorRoman Li <roman.li@amd.com>
Tue, 25 Jun 2024 17:23:36 +0000 (13:23 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 23 Jul 2024 21:07:09 +0000 (17:07 -0400)
commite8d77cfdd2698039667432b8569bac34d13508c1
tree4aee8d4d7759323efd1490ba1f520d7bd677cc5e
parent98579743c4561acc3b1c7d2f3fcd46b2160db5ba
drm/amd/display: Replace assert with error message in dp_retrieve_lttpr_cap()

[Why]
When assert in dp_retrieve_lttpr_cap() is hit, dmesg has traces like:

 RIP: 0010:dp_retrieve_lttpr_cap+0xcc/0x1a0 [amdgpu]
 Call Trace:
 <TASK>
  dp_retrieve_lttpr_cap+0xcc/0x1a0 [amdgpu]
  report_bug+0x1e8/0x240
  handle_bug+0x46/0x80
  link_detect+0x35/0x580 [amdgpu]

It happens when LTTPRs fail to increment dpcd repeater count.
We have a recovery action in place for such cases.
Assert is misleading, an indicative error in dmesg is more useful.

[How]
Remove ASSERT and use DC_LOG_ERROR instead.

Reviewed-by: Michael Strauss <michael.strauss@amd.com>
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com>
Signed-off-by: Roman Li <roman.li@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c