]> www.infradead.org Git - nvme.git/commit
net: dsa: qca8k: do not write port mask twice in bridge join/leave
authorMatthias Schiffer <mschiffer@universe-factory.net>
Thu, 20 Jun 2024 17:25:48 +0000 (19:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Jun 2024 11:22:59 +0000 (12:22 +0100)
commite85d3e6fea05c8ae21a40809a3c6b7adc97411c7
treeff92a9bb419e3562fd42fda552e174507842824b
parent28ba5c11719134b39cc593e67b15fa666cd03bd8
net: dsa: qca8k: do not write port mask twice in bridge join/leave

qca8k_port_bridge_join() set QCA8K_PORT_LOOKUP_CTRL() for i == port twice,
once in the loop handling all other port's masks, and finally at the end
with the accumulated port_mask.

The first time it would incorrectly set the port's own bit in the mask,
only to correct the mistake a moment later. qca8k_port_bridge_leave() had
the same issue, but here the regmap_clear_bits() was a no-op rather than
setting an unintended value.

Remove the duplicate assignment by skipping the whole loop iteration for
i == port. The unintended bit setting doesn't seem to have any negative
effects (even when not reverted right away), so the change is submitted
as a simple cleanup rather than a fix.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca/qca8k-common.c