]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mptcp: pm: in-kernel: avoid access entry without lock
authorGeliang Tang <tanggeliang@kylinos.cn>
Fri, 28 Feb 2025 14:38:37 +0000 (15:38 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Mar 2025 00:57:38 +0000 (16:57 -0800)
commite85d33b35508da7e7570c0b54f007b59e205f623
treed0b702b81534ac94edb46408072b4991a2ff4342
parentba24001665704d27976a2f190cd8361e339f8581
mptcp: pm: in-kernel: avoid access entry without lock

In mptcp_pm_nl_set_flags(), "entry" is copied to "local" when pernet->lock
is held to avoid direct access to entry without pernet->lock.

Therefore, "local->flags" should be passed to mptcp_nl_set_flags instead
of "entry->flags" when pernet->lock is not held, so as to avoid access to
entry.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Fixes: 145dc6cc4abd ("mptcp: pm: change to fullmesh only for 'subflow'")
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250228-net-next-mptcp-coverage-small-opti-v1-3-f933c4275676@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/pm_netlink.c