]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: rtlwifi: fix memory leaks and invalid access at probe error path
authorThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Fri, 6 Dec 2024 17:37:12 +0000 (14:37 -0300)
committerPing-Ke Shih <pkshih@realtek.com>
Thu, 12 Dec 2024 02:34:55 +0000 (10:34 +0800)
commite7ceefbfd8d447abc8aca8ab993a942803522c06
treef0fc6814a3f1ac1918b5a10c117e5b5fb3c09e52
parentd8ece6fc3694657e4886191b32ca1690af11adda
wifi: rtlwifi: fix memory leaks and invalid access at probe error path

Deinitialize at reverse order when probe fails.

When init_sw_vars fails, rtl_deinit_core should not be called, specially
now that it destroys the rtl_wq workqueue.

And call rtl_pci_deinit and deinit_sw_vars, otherwise, memory will be
leaked.

Remove pci_set_drvdata call as it will already be cleaned up by the core
driver code and could lead to memory leaks too. cf. commit 8d450935ae7f
("wireless: rtlwifi: remove unnecessary pci_set_drvdata()") and
commit 3d86b93064c7 ("rtlwifi: Fix PCI probe error path orphaned memory").

Fixes: 0c8173385e54 ("rtl8192ce: Add new driver")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241206173713.3222187-4-cascardo@igalia.com
drivers/net/wireless/realtek/rtlwifi/pci.c