]> www.infradead.org Git - users/jedix/linux-maple.git/commit
workqueue: Put the pwq after detaching the rescuer from the pool
authorLai Jiangshan <jiangshan.ljs@antgroup.com>
Thu, 23 Jan 2025 08:25:35 +0000 (16:25 +0800)
committerTejun Heo <tj@kernel.org>
Fri, 24 Jan 2025 19:29:46 +0000 (09:29 -1000)
commite76946110137703c16423baf6ee177b751a34b7e
tree248ba62e659e43dd8fa322799c97e8e1ea4f817e
parentab18b8fff124c9b76ea12692571ca822dcd92854
workqueue: Put the pwq after detaching the rescuer from the pool

The commit 68f83057b913("workqueue: Reap workers via kthread_stop() and
remove detach_completion") adds code to reap the normal workers but
mistakenly does not handle the rescuer and also removes the code waiting
for the rescuer in put_unbound_pool(), which caused a use-after-free bug
reported by Cheung Wall.

To avoid the use-after-free bug, the pool’s reference must be held until
the detachment is complete. Therefore, move the code that puts the pwq
after detaching the rescuer from the pool.

Reported-by: cheung wall <zzqq0103.hey@gmail.com>
Cc: cheung wall <zzqq0103.hey@gmail.com>
Link: https://lore.kernel.org/lkml/CAKHoSAvP3iQW+GwmKzWjEAOoPvzeWeoMO0Gz7Pp3_4kxt-RMoA@mail.gmail.com/
Fixes: 68f83057b913("workqueue: Reap workers via kthread_stop() and remove detach_completion")
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c