]> www.infradead.org Git - linux.git/commit
media: siano: Simplify smscore_load_firmware_from_file
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 5 Aug 2024 07:59:43 +0000 (07:59 +0000)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 5 Aug 2024 14:30:24 +0000 (16:30 +0200)
commite7311aa47a6ac355558bc65512aa7c381f8506ec
treeade428f3dd369166640c134c06e9dd6c0dce04b3
parent812765cd69540b1e3ed5f02e25ccb9904f6a82f7
media: siano: Simplify smscore_load_firmware_from_file

The function is never called with a loadfirmware_handler, so we can
remove some dead code.

We can also use this as a excuse to remove some unused type definitions.

This fixes the following smatch warning:
drivers/media/common/siano/smscoreapi.c:1172 smscore_load_firmware_from_file() error: we previously assumed 'loadfirmware_handler' could be null (see line 1150)

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Closes: https://lore.kernel.org/linux-media/99bd75a0-a6f3-4c47-bc89-70ffd87da756@xs4all.nl/T/#t
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/common/siano/smscoreapi.c
drivers/media/common/siano/smscoreapi.h