]> www.infradead.org Git - users/jedix/linux-maple.git/commit
alloc_tag: handle incomplete bulk allocations in vm_module_tags_populate
authorT.J. Mercier <tjmercier@google.com>
Wed, 9 Apr 2025 22:51:11 +0000 (22:51 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 12 Apr 2025 00:32:41 +0000 (17:32 -0700)
commite6e07b696da529e85d1ba880555b5df5c80a46bd
treec60d6711c3b1b9b569c816f6757e2b696bee0c74
parent0aa8dbe5a8dcaf0cc083f4a519a2906e1eb4609e
alloc_tag: handle incomplete bulk allocations in vm_module_tags_populate

alloc_pages_bulk_node() may partially succeed and allocate fewer than the
requested nr_pages.  There are several conditions under which this can
occur, but we have encountered the case where CONFIG_PAGE_OWNER is enabled
causing all bulk allocations to always fallback to single page allocations
due to commit 187ad460b841 ("mm/page_alloc: avoid page allocator recursion
with pagesets.lock held").

Currently vm_module_tags_populate() immediately fails when
alloc_pages_bulk_node() returns fewer than the requested number of pages.
When this happens memory allocation profiling gets disabled, for example

[   14.297583] [9:       modprobe:  465] Failed to allocate memory for allocation tags in the module scsc_wlan. Memory allocation profiling is disabled!
[   14.299339] [9:       modprobe:  465] modprobe: Failed to insmod '/vendor/lib/modules/scsc_wlan.ko' with args '': Out of memory

This patch causes vm_module_tags_populate() to retry bulk allocations for
the remaining memory instead of failing immediately which will avoid the
disablement of memory allocation profiling.

Link: https://lkml.kernel.org/r/20250409225111.3770347-1-tjmercier@google.com
Fixes: 0f9b685626da ("alloc_tag: populate memory for module tags as needed")
Signed-off-by: T.J. Mercier <tjmercier@google.com>
Reported-by: Janghyuck Kim <janghyuck.kim@samsung.com>
Acked-by: Suren Baghdasaryan <surenb@google.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/alloc_tag.c