]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: platform: mtk-mdp3: Fix return value check in mdp_probe()
authorQiheng Lin <linqiheng@huawei.com>
Fri, 2 Dec 2022 10:18:36 +0000 (11:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:42 +0000 (09:33 +0100)
commite68b43980a90142f932fbca366c76b034cc35d59
treef4296256a37d89cd3d14539d32768dd2efe151fa
parent9ffaf55e126cf4aad3d46198a2fe7b54cc13fbec
media: platform: mtk-mdp3: Fix return value check in mdp_probe()

[ Upstream commit 1963689bed4d500236938d90c91cdd5e63c1eb28 ]

In case of error, the function mtk_mutex_get()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
And also fix the err_free_mutex case.

Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c