]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mmc: mtk-sd: Improve data type in msdc_timeout_cal()
authorThorsten Blum <thorsten.blum@toblux.com>
Sun, 18 Aug 2024 14:23:01 +0000 (16:23 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 26 Aug 2024 11:01:50 +0000 (13:01 +0200)
commite634d9873bb13f6a91262099f545af8faf456fd0
tree0eca709c16b73ec6892eb28a4289d5cd6deb6882
parentfcd56ecaadc88b26fefebf3fb6a1787ac1d059e2
mmc: mtk-sd: Improve data type in msdc_timeout_cal()

The local variable clk_ns uses at most 32 bits and can be a u32.

Replace the 64-by-32 do_div() division with a standard divison.

Since do_div() casts the divisor to u32 anyway, changing the data type
of clk_ns to u32 also removes the following Coccinelle/coccicheck
warning reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead

Use min_t(u32,,) to simplify the code and improve its readability.

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Link: https://lore.kernel.org/r/20240818142300.64156-2-thorsten.blum@toblux.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c