]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: mpt3sas: remove redundant wmb
authorSinan Kaya <okaya@codeaurora.org>
Fri, 7 Apr 2017 19:06:18 +0000 (15:06 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 1 Jun 2017 06:07:23 +0000 (23:07 -0700)
commite6312dd3d201562b8255b12c9f266e0307d62bc8
treec040fbe6519e414c0832107f298fae490ba11ab5
parent5272fc923523e37591ee943787e8fc6d85dc5146
scsi: mpt3sas: remove redundant wmb

Orabug: 26096353

Due to relaxed ordering requirements on multiple architectures, drivers
are required to use wmb/rmb/mb combinations when they need to guarantee
observability between the memory and the HW.

The mpt3sas driver is already using wmb() for this purpose.  However, it
issues a writel following wmb(). writel() function on arm/arm64
arhictectures have an embedded wmb() call inside.

This results in unnecessary performance loss and code duplication.

writel already guarantees ordering for both cpu and bus. we don't need
additional wmb()

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit b1391a5bf83a593bbe92d1f9bddaf563be5c7c9d)
Signed-off-by: Shan Hai <shan.hai@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c