]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: Fix gso_features_check to check for both dev->gso_{ipv4_,}max_size
authorDaniel Borkmann <daniel@iogearbox.net>
Mon, 23 Sep 2024 21:22:42 +0000 (23:22 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 1 Oct 2024 08:48:52 +0000 (10:48 +0200)
commite609c959a939660c7519895f853dfa5624c6827a
tree898a1b9ecec3af1a030dcd79028bfe7726d93067
parente8d4d34df715133c319fabcf63fdec684be75ff8
net: Fix gso_features_check to check for both dev->gso_{ipv4_,}max_size

Commit 24ab059d2ebd ("net: check dev->gso_max_size in gso_features_check()")
added a dev->gso_max_size test to gso_features_check() in order to fall
back to GSO when needed.

This was added as it was noticed that some drivers could misbehave if TSO
packets get too big. However, the check doesn't respect dev->gso_ipv4_max_size
limit. For instance, a device could be configured with BIG TCP for IPv4,
but not IPv6.

Therefore, add a netif_get_gso_max_size() equivalent to netif_get_gro_max_size()
and use the helper to respect both limits before falling back to GSO engine.

Fixes: 24ab059d2ebd ("net: check dev->gso_max_size in gso_features_check()")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20240923212242.15669-2-daniel@iogearbox.net
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
include/linux/netdevice.h
net/core/dev.c