]> www.infradead.org Git - users/dwmw2/linux.git/commit
dm thin: fix issue_discard to pass GFP_NOIO to __blkdev_issue_discard
authorMike Snitzer <snitzer@kernel.org>
Wed, 14 Jun 2023 00:05:34 +0000 (20:05 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jun 2023 14:02:10 +0000 (16:02 +0200)
commite5d9e0107993434f12798ca3794392d9ab3d2f34
tree2e9089406feafca6322266133a235429431be448
parenta548701d0b0d5e045d1704a04c35213b390bd2ea
dm thin: fix issue_discard to pass GFP_NOIO to __blkdev_issue_discard

commit 722d90822321497e2837cfc9000202e256e6b32f upstream.

issue_discard() passes GFP_NOWAIT to __blkdev_issue_discard() despite
its code assuming bio_alloc() always succeeds.

Commit 3dba53a958a75 ("dm thin: use __blkdev_issue_discard for async
discard support") clearly shows where things went bad:

Before commit 3dba53a958a75, dm-thin.c's open-coded
__blkdev_issue_discard_async() properly handled using GFP_NOWAIT.
Unfortunately __blkdev_issue_discard() doesn't and it was missed
during review.

Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-thin.c