]> www.infradead.org Git - users/hch/misc.git/commit
usb: gadget: uvc: Fix unstarted kthread worker
authorFrederic Weisbecker <frederic@kernel.org>
Wed, 12 Feb 2025 13:55:14 +0000 (14:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2025 08:26:00 +0000 (09:26 +0100)
commite5644be4079750a0a0a5a7068fd90b97bf6fac55
treeb5eb732b994f1fdd9206a5f8db62cefcf46f4347
parente169d96eecd447ff7fd7542ca5fa0911f5622054
usb: gadget: uvc: Fix unstarted kthread worker

The behaviour of kthread_create_worker() was recently changed to align
with the one of kthread_create(). The kthread worker is created but not
awaken by default. This is to allow the use of kthread_affine_preferred()
and kthread_bind[_mask]() with kthread workers. In order to keep the
old behaviour and wake the kthread up, kthread_run_worker() must be
used. All the pre-existing users have been converted, except for UVC
that was introduced in the same merge window as the API change.

This results in hangs:

INFO: task UVCG:82 blocked for more than 491 seconds.
Tainted: G                T  6.13.0-rc2-00014-gb04e317b5226 #1
task:UVCG            state:D stack:0     pid:82
 Call Trace:
 __schedule
 schedule
 schedule_preempt_disabled
 kthread
 ? kthread_flush_work
 ret_from_fork
 ret_from_fork_asm
 entry_INT80_32

Fix this with converting UVCG kworker to the new API.

Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202502121025.55bfa801-lkp@intel.com
Fixes: f0bbfbd16b3b ("usb: gadget: uvc: rework to enqueue in pump worker from encoded queue")
Cc: stable <stable@kernel.org>
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20250212135514.30539-1-frederic@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/uvc_video.c