]> www.infradead.org Git - users/jedix/linux-maple.git/commit
accel/ivpu: Fix locking order in ivpu_cmdq_destroy_ioctl
authorKarol Wachowski <karol.wachowski@intel.com>
Tue, 7 Jan 2025 17:32:33 +0000 (18:32 +0100)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Thu, 9 Jan 2025 08:35:45 +0000 (09:35 +0100)
commite52443608934952fc978234cf7d639d6aa3f1856
tree02cba7ef8f3c65f344e3766731b580fbb2cf39d7
parentae06e0b3bfe07321c6a865df1b701e64194ec66e
accel/ivpu: Fix locking order in ivpu_cmdq_destroy_ioctl

Fix deadlock caused by inversed locking order in ivpu_job_submit()
and ivpu_cmdq_destroy_ioctl(). Both functions operate locking
file_priv->lock and submitted_jobs_lock.

Unlock file_priv->lock in ivpu_cmdq_destroy_ioctl() before calling
ivpu_cmdq_abort_all_jobs() function which locks submitted_jobs_lock.
That way locking order is maintained:
 1) global submitted_jobs_lock first
 2) per context file_priv->lock second

Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250107173238.381120-11-maciej.falkowski@linux.intel.com
drivers/accel/ivpu/ivpu_job.c