]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64/cpufeature: Refactor conditional logic in init_cpu_ftr_reg()
authorHardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Fri, 15 Nov 2024 05:36:35 +0000 (11:06 +0530)
committerWill Deacon <will@kernel.org>
Tue, 10 Dec 2024 12:16:19 +0000 (12:16 +0000)
commite52163df77215c991cf4b6439f64c6331fd7dbfb
tree4e04f5ee91ffe8a5c005496f60d9ab71de0b4a60
parent264a593da60b60c4f8f218ac50cd1305d75387e8
arm64/cpufeature: Refactor conditional logic in init_cpu_ftr_reg()

Unnecessarily checks ftr_ovr == tmp in an extra else if, which is not
needed because that condition would already be true by default if the
previous conditions are not satisfied.

if (ftr_ovr != tmp) {
} else if (ftr_new != tmp) {
} else if (ftr_ovr == tmp) {

Logic: The first and last conditions are inverses of each other, so
the last condition must be true if the first two conditions are false.

Additionally, all branches set the variable str, making the subsequent
"if (str)" check redundant

Reviewed-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Link: https://lore.kernel.org/r/20241115053740.20523-1-hardevsinh.palaniya@siliconsignals.io
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/cpufeature.c