]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/vc4: Drop planes that are completely off-screen or 0 crtc size
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Fri, 25 Oct 2024 17:15:59 +0000 (18:15 +0100)
committerDave Stevenson <dave.stevenson@raspberrypi.com>
Wed, 27 Nov 2024 14:37:21 +0000 (14:37 +0000)
commite511f8fc3b2786999987901dad94c1548e091040
tree987ee89ceae8c451a278a4d311b28c96c3890704
parent52b0a073167b3679f7dd754903d84dfdc8119211
drm/vc4: Drop planes that are completely off-screen or 0 crtc size

It is permitted for a plane to be configured such that none
of it is on-screen via either negative dest rectangle X,Y
offset, or an offset that is greater than the crtc dimensions.

These planes were resized via drm_atomic_helper_check_plane_state
such that the source rectangle had a zero width or height, but
they still created a dlist entry even though they contributed
no pixels. In the case of vc6_plane_mode_set, that it could result
in negative values being written into registers, which caused
incorrect behaviour.

Drop planes that result in a source width or height of 0 pixels
or an on-screen size of 0 pixels to avoid the incorrect rendering.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241025-drm-vc4-2712-support-v2-28-35efa83c8fc0@raspberrypi.com
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_plane.c