]> www.infradead.org Git - users/jedix/linux-maple.git/commit
can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 30 Sep 2024 17:02:30 +0000 (19:02 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 4 Nov 2024 17:01:06 +0000 (18:01 +0100)
commite4de81f9e134c78ff7c75a00e43bd819643530d0
treea0493e2d8e91b799141c1d96bd8b0c54f9aa4369
parent7b22846f8af5ab2f267de9eb209fb1835ee9978c
can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices

In commit b382380c0d2d ("can: m_can: Add hrtimer to generate software
interrupt") support for IRQ-less devices was added. Instead of an
interrupt, the interrupt routine is called by a hrtimer-based polling
loop.

That patch forgot to change free_irq() to be only called for devices
with IRQs. Fix this, by calling free_irq() conditionally only if an
IRQ is available for the device (and thus has been requested
previously).

Fixes: b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Link: https://patch.msgid.link/20240930-m_can-cleanups-v1-1-001c579cdee4@pengutronix.de
Cc: <stable@vger.kernel.org> # v6.6+
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c