]> www.infradead.org Git - users/jedix/linux-maple.git/commit
of: Correct child specifier used as input of the 2nd nexus node
authorZijun Hu <quic_zijuhu@quicinc.com>
Thu, 9 Jan 2025 13:26:52 +0000 (21:26 +0800)
committerRob Herring (Arm) <robh@kernel.org>
Fri, 10 Jan 2025 17:38:26 +0000 (11:38 -0600)
commite4c00c9b1f70cd11792ff5b825899a6ee0234a62
tree65d404f85dc4fa5949d3c307197b12b27b45319e
parent55e6502ef7114688e294e6835cf1635f4f1ba214
of: Correct child specifier used as input of the 2nd nexus node

API of_parse_phandle_with_args_map() will use wrong input for nexus node
Nexus_2 as shown below:

    Node_1 Nexus_1                              Nexus_2
&Nexus_1,arg_1 -> arg_1,&Nexus_2,arg_2' -> &Nexus_2,arg_2 -> arg_2,...
  map-pass-thru=<...>

Nexus_1's output arg_2 should be used as input of Nexus_2, but the API
wrongly uses arg_2' instead which != arg_2 due to Nexus_1's map-pass-thru.

Fix by always making @match_array point to @initial_match_array into
which to store nexus output.

Fixes: bd6f2fd5a1d5 ("of: Support parsing phandle argument lists through a nexus node")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250109-of_core_fix-v4-1-db8a72415b8c@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/base.c