]> www.infradead.org Git - users/jedix/linux-maple.git/commit
smb3: fix broken cached reads when posix locks
authorSteve French <stfrench@microsoft.com>
Thu, 15 Aug 2024 23:31:36 +0000 (18:31 -0500)
committerSteve French <stfrench@microsoft.com>
Sun, 18 Aug 2024 22:01:06 +0000 (17:01 -0500)
commite4be320eeca842a3d7648258ee3673f1755a5a59
treeb928c670bf7894fc5391e727e704bec8a9a0e451
parent47ac09b91befbb6a235ab620c32af719f8208399
smb3: fix broken cached reads when posix locks

Mandatory locking is enforced for cached reads, which violates
default posix semantics, and also it is enforced inconsistently.
This affected recent versions of libreoffice, and can be
demonstrated by opening a file twice from the same client,
locking it from handle one and trying to read from it from
handle two (which fails, returning EACCES).

There is already a mount option "forcemandatorylock"
(which defaults to off), so with this change only when the user
intentionally specifies "forcemandatorylock" on mount will we
break posix semantics on read to a locked range (ie we will
only fail in this case, if the user mounts with
"forcemandatorylock").

An earlier patch fixed the write path.

Fixes: 85160e03a79e ("CIFS: Implement caching mechanism for mandatory brlocks")
Cc: stable@vger.kernel.org
Cc: Pavel Shilovsky <piastryyy@gmail.com>
Reviewed-by: David Howells <dhowells@redhat.com>
Reported-by: abartlet@samba.org
Reported-by: Kevin Ottens <kevin.ottens@enioka.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/file.c