]> www.infradead.org Git - users/jedix/linux-maple.git/commit
svcrpc: sends on closed socket should stop immediately
authorJ. Bruce Fields <bfields@redhat.com>
Mon, 20 Aug 2012 20:04:40 +0000 (16:04 -0400)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Mon, 8 Oct 2012 10:39:37 +0000 (03:39 -0700)
commite4977a47f611b9b548b4eb60548552e240355d28
treee426fe978b154682c5f918d571673df9c854361e
parent6bb2b3ef9d62085af4977868594679b1ea6f01a4
svcrpc: sends on closed socket should stop immediately

commit f06f00a24d76e168ecb38d352126fd203937b601 upstream.

svc_tcp_sendto sets XPT_CLOSE if we fail to transmit the entire reply.
However, the XPT_CLOSE won't be acted on immediately.  Meanwhile other
threads could send further replies before the socket is really shut
down.  This can manifest as data corruption: for example, if a truncated
read reply is followed by another rpc reply, that second reply will look
to the client like further read data.

Symptoms were data corruption preceded by svc_tcp_sendto logging
something like

kernel: rpc-srv/tcp: nfsd: sent only 963696 when sending 1048708 bytes - shutting down socket

Reported-by: Malahal Naineni <malahal@us.ibm.com>
Tested-by: Malahal Naineni <malahal@us.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/svc_xprt.c