]> www.infradead.org Git - users/hch/misc.git/commit
eth: bnxt: fix deadlock in the mgmt_ops
authorTaehee Yoo <ap420073@gmail.com>
Wed, 2 Apr 2025 13:31:23 +0000 (13:31 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Apr 2025 22:10:52 +0000 (15:10 -0700)
commite4546c6498c68ba65929fcbcf54ff1947fe53f48
tree21da035d415fd90602fcc956635a18f67dbe91f8
parente5ddf19dbc3e24cce508de0dab0e8df5b7417de8
eth: bnxt: fix deadlock in the mgmt_ops

When queue is being reset, callbacks of mgmt_ops are called by
netdev_nl_bind_rx_doit().
The netdev_nl_bind_rx_doit() first acquires netdev_lock() and then calls
callbacks.
So, mgmt_ops callbacks should not acquire netdev_lock() internaly.

The bnxt_queue_{start | stop}() calls napi_{enable | disable}() but they
internally acquire netdev_lock().
So, deadlock occurs.

To avoid deadlock, napi_{enable | disable}_locked() should be used
instead.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Fixes: cae03e5bdd9e ("net: hold netdev instance lock during queue operations")
Link: https://patch.msgid.link/20250402133123.840173-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c