]> www.infradead.org Git - nvme.git/commit
HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to...
authorKaixin Wang <kxwang23@m.fudan.edu.cn>
Wed, 18 Sep 2024 12:07:50 +0000 (20:07 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 25 Feb 2025 01:07:09 +0000 (02:07 +0100)
commite3f88665a78045fe35c7669d2926b8d97b892c11
tree03503f48f49ba337277d7b26fd1e20f809c1ebc5
parent2014c95afecee3e76ca4a56956a936e23283f05b
HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition

In the ssi_protocol_probe() function, &ssi->work is bound with
ssip_xmit_work(), In ssip_pn_setup(), the ssip_pn_xmit() function
within the ssip_pn_ops structure is capable of starting the
work.

If we remove the module which will call ssi_protocol_remove()
to make a cleanup, it will free ssi through kfree(ssi),
while the work mentioned above will be used. The sequence
of operations that may lead to a UAF bug is as follows:

CPU0                                    CPU1

                        | ssip_xmit_work
ssi_protocol_remove     |
kfree(ssi);             |
                        | struct hsi_client *cl = ssi->cl;
                        | // use ssi

Fix it by ensuring that the work is canceled before proceeding
with the cleanup in ssi_protocol_remove().

Signed-off-by: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240918120749.1730-1-kxwang23@m.fudan.edu.cn
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/hsi/clients/ssi_protocol.c