]> www.infradead.org Git - users/jedix/linux-maple.git/commit
powerpc/boot: Fix dash warning
authorMadhavan Srinivasan <maddy@linux.ibm.com>
Wed, 23 Apr 2025 08:21:54 +0000 (13:51 +0530)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Thu, 24 Apr 2025 06:55:39 +0000 (12:25 +0530)
commite3f506b78d921e48a00d005bea5c45ec36a99240
treedef525c5e108745a426020a5f7e1c0ad13d0656c
parentb2accfe7ca5bc9f9af28e603b79bdd5ad8df5c0b
powerpc/boot: Fix dash warning

'commit b2accfe7ca5b ("powerpc/boot: Check for ld-option support")' suppressed
linker warnings, but the expressed used did not go well with POSIX shell (dash)
resulting with this warning

arch/powerpc/boot/wrapper: 237: [: 0: unexpected operator
ld: warning: arch/powerpc/boot/zImage.epapr has a LOAD segment with RWX permissions

Fix the check to handle the reported warning. Patch also fixes
couple of shellcheck reported errors for the same line.

In arch/powerpc/boot/wrapper line 237:
if [ $(${CROSS}ld -v --no-warn-rwx-segments &>/dev/null; echo $?) -eq 0 ]; then
     ^-- SC2046 (warning): Quote this to prevent word splitting.
       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                            ^---------^ SC3020 (warning): In POSIX sh, &> is undefined.

Fixes: b2accfe7ca5b ("powerpc/boot: Check for ld-option support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250423082154.30625-1-maddy@linux.ibm.com
arch/powerpc/boot/wrapper