]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: seq: Improve data consistency at polling
authorTakashi Iwai <tiwai@suse.de>
Fri, 7 Mar 2025 08:42:42 +0000 (09:42 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 7 Mar 2025 08:44:35 +0000 (09:44 +0100)
commite3cd33ab17c33bd8f1a9df66ec83a15dd8f7afbb
treeedddd0842fa1923d20e9bc7129be92a63b14eacf
parentaa85822c611aef7cd4dc17d27121d43e21bb82f0
ALSA: seq: Improve data consistency at polling

snd_seq_poll() calls snd_seq_write_pool_allocated() that reads out a
field in client->pool object, while it can be updated concurrently via
ioctls, as reported by syzbot.  The data race itself is harmless, as
it's merely a poll() call, and the state is volatile.  OTOH, the read
out of poll object info from the caller side is fragile, and we can
leave it better in snd_seq_pool_poll_wait() alone.

A similar pattern is seen in snd_seq_kernel_client_write_poll(), too,
which is called from the OSS sequencer.

This patch drops the pool checks from the caller side and add the
pool->lock in snd_seq_pool_poll_wait() for better data consistency.

Reported-by: syzbot+2d373c9936c00d7e120c@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/67c88903.050a0220.15b4b9.0028.GAE@google.com
Link: https://patch.msgid.link/20250307084246.29271-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_clientmgr.c
sound/core/seq/seq_memory.c