]> www.infradead.org Git - users/jedix/linux-maple.git/commit
leds: multicolor: Fix intensity setting while SW blinking
authorSven Schwermer <sven.schwermer@disruptive-technologies.com>
Fri, 4 Apr 2025 18:40:36 +0000 (20:40 +0200)
committerLee Jones <lee@kernel.org>
Wed, 14 May 2025 08:24:45 +0000 (09:24 +0100)
commite35ca991a777ef513040cbb36bc8245a031a2633
treeaad31d6ecc35c0112af814f287d0c46dcdc439c8
parentb2661df9febda90b2bc7e5b867431c8433f49e79
leds: multicolor: Fix intensity setting while SW blinking

When writing to the multi_intensity file, don't unconditionally call
led_set_brightness. By only doing this if blinking is inactive we
prevent blinking from stopping if the blinking is in its off phase while
the file is written.

Instead, if blinking is active, the changed intensity values are applied
upon the next blink. This is consistent with changing the brightness on
monochrome LEDs with active blinking.

Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Tobias Deiminger <tobias.deiminger@linutronix.de>
Tested-by: Sven Schuchmann <schuchmann@schleissheimer.de>
Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
Link: https://lore.kernel.org/r/20250404184043.227116-1-sven@svenschwermer.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/led-class-multicolor.c