]> www.infradead.org Git - users/dwmw2/linux.git/commit
ARM: 8808/1: kexec:offline panic_smp_self_stop CPU
authorYufen Wang <wangyufen@huawei.com>
Fri, 2 Nov 2018 10:51:31 +0000 (11:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 19:02:06 +0000 (20:02 +0100)
commite33590dc8a83cf3ae40403a3f69b5c4c8f77dba6
tree43ea74e4aa482acfbb7f5a45602a005b51793398
parent8f36e264f7a960a041d32d523511f7b91419dc72
ARM: 8808/1: kexec:offline panic_smp_self_stop CPU

[ Upstream commit 82c08c3e7f171aa7f579b231d0abbc1d62e91974 ]

In case panic() and panic() called at the same time on different CPUS.
For example:
CPU 0:
  panic()
     __crash_kexec
       machine_crash_shutdown
         crash_smp_send_stop
       machine_kexec
         BUG_ON(num_online_cpus() > 1);

CPU 1:
  panic()
    local_irq_disable
    panic_smp_self_stop

If CPU 1 calls panic_smp_self_stop() before crash_smp_send_stop(), kdump
fails. CPU1 can't receive the ipi irq, CPU1 will be always online.
To fix this problem, this patch split out the panic_smp_self_stop()
and add set_cpu_online(smp_processor_id(), false).

Signed-off-by: Yufen Wang <wangyufen@huawei.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/kernel/smp.c