]> www.infradead.org Git - users/dwmw2/linux.git/commit
KVM: x86: Avoid gratuitous global clock reload in kvm_arch_vcpu_load()
authorDavid Woodhouse <dwmw@amazon.co.uk>
Sun, 28 Apr 2024 12:59:49 +0000 (13:59 +0100)
committerDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 22 May 2024 00:05:41 +0000 (17:05 -0700)
commite3105770a46661e5dc8db4f3afb801a1bc6d9eb2
treee75a6929133f7ffb845f26bdb0489466c93c42f3
parentcbf37e78439e42e6a82ae1c6825bb9ed62b64254
KVM: x86: Avoid gratuitous global clock reload in kvm_arch_vcpu_load()

Commit d98d07ca7e034 ("KVM: x86: update pvclock area conditionally, on
cpu migration") turned an unconditional KVM_REQ_CLOCK_UPDATE into a
conditional one, if either the master clock isn't enabled *or* the vCPU
was not previously scheduled (vcpu->cpu == -1). The commit message doesn't
explain the latter condition, which is specifically for the master clock
case.

Commit 0061d53daf26f ("KVM: x86: limit difference between kvmclock
updates") later turned that into a KVM_REQ_GLOBAL_CLOCK_UPDATE to avoid
skew between vCPUs.

In master clock mode there is no need for any of that, regardless of
whether/where this vCPU was previously scheduled.

Do it only if (!kvm->arch.use_master_clock).

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
arch/x86/kvm/x86.c