]> www.infradead.org Git - users/dwmw2/linux.git/commit
firewire: core: update fw_device outside of device_find_child()
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 20 Aug 2024 13:21:32 +0000 (22:21 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 20 Aug 2024 13:21:32 +0000 (22:21 +0900)
commite2c87f484190b12fedcea9c428906aafcb8783cf
treeea3cfb3c7585d320540932c1aba1e0e1c636c25d
parent52f9fcbc7b11b305306c879fcc545d075066bee0
firewire: core: update fw_device outside of device_find_child()

When detecting updates of bus topology, the data of fw_device is newly
allocated and caches the content of configuration ROM from the
corresponding node. Then, the tree of device is sought to find the
previous data of fw_device corresponding to the node. If found, the
previous data is updated and reused and the data of fw_device newly
allocated is going to be released.

The above procedure is done in the call of device_find_child(), however it
is a bit abusing against the intention of the helper function, since it is
preferable to find only without updating.

This commit splits the update outside of the call.

Cc: Zijun Hu <zijun_hu@icloud.com>
Link: https://lore.kernel.org/r/20240820132132.28839-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/core-device.c