]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: lpfc: Correct MDS diag and nvmet configuration
authorJames Smart <jsmart2021@gmail.com>
Thu, 16 Aug 2018 23:04:05 +0000 (16:04 -0700)
committerBrian Maly <brian.maly@oracle.com>
Tue, 20 Nov 2018 19:22:25 +0000 (14:22 -0500)
commite2ad25add0a354aad0c822def69bdbc1a6449ad9
treeedb8300a43be7a780a2e461e0dcccb17367e6b5a
parent5dfc30b002caa8897f45d49a50c29c572f9034fd
scsi: lpfc: Correct MDS diag and nvmet configuration

Orabug: 28855939

A recent change added some MDS processing in the lpfc_drain_txq routine
that relies on the fcp_wq being allocated. For nvmet operation the fcp_wq
is not allocated because it can only be an nvme-target.  When the original
MDS support was added LS_MDS_LOOPBACK was defined wrong, (0x16) it should
have been 0x10 (decimal value used for hex setting). This incorrect value
allowed MDS_LOOPBACK to be set simultaneously with LS_NPIV_FAB_SUPPORTED,
causing the driver to crash when it accesses the non-existent fcp_wq.

Correct the bad value setting for LS_MDS_LOOPBACK.

Fixes: ae9e28f36a6c ("lpfc: Add MDS Diagnostic support.")
Cc: <stable@vger.kernel.org> # v4.12+
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Tested-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit 53e13ee087a80e8d4fc95436318436e5c2c1f8c2)
Signed-off-by: Dan Duval <dan.duval@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/scsi/lpfc/lpfc.h